all: treat clang-tidy warnings as errors #1745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yperbasis
added
the
maintenance
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1745 +/- ##
==========================================
- Coverage 52.74% 52.71% -0.03%
==========================================
Files 599 599
Lines 44770 44770
Branches 6947 6947
==========================================
- Hits 23615 23602 -13
- Misses 19091 19099 +8
- Partials 2064 2069 +5 ☔ View full report in Codecov by Sentry. |
chfast
reviewed
Jan 11, 2024
CMakeLists.txt
Outdated
| @@ -91,7 +91,7 @@ include(${CMAKE_CURRENT_SOURCE_DIR}/cmake/compiler_warnings.cmake) | |||
| if(SILKWORM_CLANG_TIDY) | |||
| find_program(CLANG_TIDY clang-tidy REQUIRED) | |||
| set(CMAKE_C_CLANG_TIDY "${CLANG_TIDY};-warnings-as-errors=*") | |||
| set(CMAKE_CXX_CLANG_TIDY "${CLANG_TIDY}") | |||
| set(CMAKE_CXX_CLANG_TIDY "${CLANG_TIDY};-warnings-as-errors=*") | |||
There was a problem hiding this comment.
You can control this from the config.
canepat
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.